Skip to content

Max per page #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

dee-kryvenko
Copy link
Contributor

Resolves #2557


Before the change?

Added a new max_per_page configuration option to the provider block backed by GITHUB_MAX_PER_PAGE env variable as default fn.

After the change?

Current behavior remains backward compatible as the default is still set to 100.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@dee-kryvenko
Copy link
Contributor Author

I wanted to add it as a param to Config struct but the whole shenanigans with Config not being available in the runtime context and instead having the Meta() as interface{} and the casting - I am baffled what is going on in there, and didn't want to touch any of that. This should be safe enough since TF guarantees ConfigureContextFunc to be called thread safely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: github_organization_team_sync_groups causing unhandled 429 (Too Many Attempts) errors
1 participant