Conversation
Signed-off-by: He, Xin3 <xin3.he@intel.com>
|
@copilot please help update the description |
There was a problem hiding this comment.
Pull request overview
This PR refactors the evaluation system by extracting evaluation logic into separate functions, adding vLLM backend support with custom arguments, and improving code organization.
Changes:
- Removed unused imports and deprecated VLLM integration test
- Replaced verbose VLLM argument parser with a single
--vllm_argsparameter accepting comma-separated key-value pairs - Extracted evaluation logic into dedicated functions in
evaluation.pyfor better modularity
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/test_cuda/integrations/test_vllm.py | Removed unused imports and deprecated test_vllm_lm_eval test function |
| test/test_cuda/advanced/test_evaluation.py | Added new tests for VLLM and HF evaluation backends with custom arguments |
| test/test_cpu/advanced/test_evaluation_functions.py | Added unit tests for VLLM argument parsing and GGUF model loading utilities |
| auto_round/utils/model.py | Added support for Qwen3Next and Qwen3VLMoeText MoE blocks |
| auto_round/eval/evaluation.py | Added helper functions for diffusion models, GGUF loading, and model evaluation routing |
| auto_round/eval/eval_cli.py | Refactored VLLM argument handling to use parse_vllm_args and extracted GGUF loading logic |
| auto_round/main.py | Replaced inline evaluation code with call to run_model_evaluation function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: He, Xin3 <xin3.he@intel.com>
Signed-off-by: He, Xin3 <xin3.he@intel.com>
for more information, see https://pre-commit.ci
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: He, Xin3 <xin3.he@intel.com>
Signed-off-by: He, Xin3 <xin3.he@intel.com>
|
…e limit Signed-off-by: He, Xin3 <xin3.he@intel.com>
…val_with_vllm Signed-off-by: He, Xin3 <xin3.he@intel.com>
…cesses Signed-off-by: He, Xin3 <xin3.he@intel.com>
…trings Signed-off-by: He, Xin3 <xin3.he@intel.com>
…m_args Signed-off-by: He, Xin3 <xin3.he@intel.com>
Signed-off-by: He, Xin3 <xin3.he@intel.com>
|
Please make sure this use case is supported |
Sure, verified with |
Signed-off-by: He, Xin3 <xin3.he@intel.com>
Signed-off-by: He, Xin3 <xin3.he@intel.com>
|
HPU, XPU are verified. |
Signed-off-by: He, Xin3 <xin3.he@intel.com>
Signed-off-by: He, Xin3 <xin3.he@intel.com>
Description
Type of Change
Related Issues
Fixes #1319 #1050
Relates to #1134
Changes Made
Refactored evaluation functionality into a dedicated
auto_round/evalmodule and added comprehensive unit tests for CPU and GPU backends.Module Structure
auto_round/eval/eval_cli.py(486 lines): CLI argument parsing, vLLM/HF backend orchestration, custom argument parsing [for pure quantization with--eval]auto_round/eval/evaluation.py(439 lines): Core evaluation wrappers forlm_evallibrary [for evaluation after quantziation]Unit Tests
test/test_cpu/advanced/test_evaluation_functions.py(121 lines): Tests forparse_vllm_args()with various types (int, float, bool, string, mixed)test/test_cuda/advanced/test_evaluation.py(115 lines): Integration tests for vLLM backend with custom args, quantization workflowsCompatibility & Optimization
allow_deprecated_quantization: Truefor vLLM 0.14.0 compatibilityExample Usage
Testing
Checklist
Additional Context