Merged
Conversation
Signed-off-by: Mengni Wang <mengni.wang@intel.com>
for more information, see https://pre-commit.ci
Contributor
|
Really nice catch! Thanks! |
xin3he
approved these changes
Mar 25, 2026
for more information, see https://pre-commit.ci
Signed-off-by: Mengni Wang <mengni.wang@intel.com>
Contributor
|
based on the data,I still recommend using rtn |
Contributor
Author
okay |
for more information, see https://pre-commit.ci
wenhuach21
reviewed
Mar 26, 2026
Contributor
|
/azp run Unit-Test-CUDA-AutoRound |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fp8 quant_func only use weight.max() for scale calculation when tuning
Type of Change
acc before:
acc after: