Fix two bugs related to pseudo pext indirect lookup with search #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukevalenty
force-pushed
the
lukevalenty/pseudo_pext_lookup_indirect_search_fix
branch
from
344588f to
e0a87d9
Compare
elbeno
approved these changes
Oct 9, 2024
lukevalenty
deleted the
lukevalenty/pseudo_pext_lookup_indirect_search_fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding random tests to the lookup library I found a couple of bugs. Making the fix here along with tests that hit the failing scenarios.