🐛 Fix path calculations for gen_str_catalog
#669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - Users of the function may pass in qualified path names for inputs; it's not correct to simply prepend the current source directory. Solution: - Use `file(REAL_PATH ...)` to calculate the path, which will properly handle either a qualified path or a path relative to the current source directory. Note: - CMake is limited in `list(TRANSFORM ...)` to fixed functions, hence this must be done with a regular `foreach`.
lukevalenty
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
file(REAL_PATH ...)to calculate the path, which will properly handle either a qualified path or a path relative to the current source directory.Note:
list(TRANSFORM ...)to fixed functions, hence this must be done with a regularforeach.