Skip to content

✨ Add check for module ID limit #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2025
Merged

✨ Add check for module ID limit #677

merged 1 commit into from
Jan 13, 2025

Conversation

elbeno
Copy link
Contributor

@elbeno elbeno commented Jan 11, 2025

Problem:

  • The MIPI-SyST spec allows 7 bits for the module ID field. A codebase could accidentally exceed this limit, leading to unpredictable effects.

Solution:

  • Check the max value of a module is not exceeded.
  • Allow the max value to be customized so that alternative backends can provide alternative limits.

@elbeno
✨ Add check for module ID limit
7808e69 
Problem:
- The MIPI-SyST spec allows 7 bits for the module ID field. A codebase could
  accidentally exceed this limit, leading to unpredictable effects.

Solution:
- Check the max value of a module is not exceeded.
- Allow the max value to be customized so that alternative backends can provide
  alternative limits.
@elbeno elbeno marked this pull request as ready for review January 11, 2025 03:11
@bdeane-intel bdeane-intel merged commit 3545e85 into intel:main Jan 13, 2025
22 checks passed
@elbeno elbeno deleted the add-module-id-max branch January 17, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcaisse-intel mjcaisse-intel mjcaisse-intel approved these changes

@lukevalenty lukevalenty Awaiting requested review from lukevalenty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elbeno @mjcaisse-intel @bdeane-intel