🎨 Allow extra arguments to CIB_FATAL #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - `CIB_FATAL` expects log arguments to be interpolated into the format string, but there is no way to pass extra arguments along to `stdx::panic`. Solution: - Use the `format_result` tuple as the first argument to `stdx::panic`, and allow any further arguments passed to `CIB_FATAL` to be forwarded through. Note: - Splitting a tuple may be worthwhile to move to stdx in due course. Surprisingly I don't think we've had cause for it yet. And since clang backports pack indexing, when that is available we can use it without pulling in `stdx::tuple`.
mjcaisse-intel
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
CIB_FATALexpects log arguments to be interpolated into the format string, but there is no way to pass extra arguments along tostdx::panic.Solution:
format_resulttuple as the first argument tostdx::panic, and allow any further arguments passed toCIB_FATALto be forwarded through.Note:
stdx::tuple.