Skip to content

Conversation

elbeno
Copy link
Contributor

@elbeno elbeno commented Mar 31, 2025

Problem:

  • CIB_FATAL expects log arguments to be interpolated into the format string, but there is no way to pass extra arguments along to stdx::panic.

Solution:

  • Use the format_result tuple as the first argument to stdx::panic, and allow any further arguments passed to CIB_FATAL to be forwarded through.

Note:

  • Splitting a tuple may be worthwhile to move to stdx in due course. Surprisingly I don't think we've had cause for it yet. And since clang backports pack indexing, when that is available we can use it without pulling in stdx::tuple.

Problem:
- `CIB_FATAL` expects log arguments to be interpolated into the format string,
  but there is no way to pass extra arguments along to `stdx::panic`.

Solution:
- Use the `format_result` tuple as the first argument to `stdx::panic`, and allow
  any further arguments passed to `CIB_FATAL` to be forwarded through.

Note:
- Splitting a tuple may be worthwhile to move to stdx in due course.
  Surprisingly I don't think we've had cause for it yet. And since clang
  backports pack indexing, when that is available we can use it without pulling
  in `stdx::tuple`.
@bdeane-intel bdeane-intel merged commit ba9dd15 into intel:main Mar 31, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants