Skip to content

🐛 Make field_name assignment operation const #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

🐛 Make field_name assignment operation const #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/msg/message.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ template <stdx::ct_string Name> struct field_name {
using name_t = stdx::cts_t<Name>;

// NOLINTNEXTLINE(misc-unconventional-assign-operator)
template <typename T> constexpr auto operator=(T value) {
template <typename T> constexpr auto operator=(T value) const {
return field_value<Name, T>{value};
}

Expand Down
9 changes: 9 additions & 0 deletions test/msg/message.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,15 @@ TEST_CASE("construct with field values", "[message]") {
CHECK(0x0042'd00d == data[1]);
}

TEST_CASE("use field names as template args", "[message]") {
auto msg = []<auto F>() {
return test_msg{F = 0xba11};
}.template operator()<"f1"_field>();

auto const data = msg.data();
CHECK(0x8000'ba11 == data[0]);
}

TEST_CASE("construct with field defaults", "[message]") {
test_msg msg{};

Expand Down
Loading