Skip to content

🎨 Add constexpr to a message view constructor #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

🎨 Add constexpr to a message view constructor #741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions include/msg/message.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ struct message {

template <detail::storage_like S>
// NOLINTNEXTLINE(google-explicit-constructor)
explicit(false) view_t(S const &s) : storage{s} {}
constexpr explicit(false) view_t(S const &s) : storage{s} {}

template <detail::storage_like S, some_field_value... Vs>
constexpr explicit view_t(S &s, Vs... vs) : storage{s} {
Expand All @@ -400,7 +400,7 @@ struct message {
: storage{s.data()} {}

template <typename S, some_field_value... Vs>
explicit(true) constexpr view_t(owner_t<S> &s LIFETIMEBOUND, Vs... vs)
constexpr explicit(true) view_t(owner_t<S> &s LIFETIMEBOUND, Vs... vs)
: storage{s.data()} {
this->set(vs...);
}
Expand Down Expand Up @@ -470,7 +470,7 @@ struct message {
this->set(Fields{}...);
}

template <some_field_value... Vs> explicit constexpr owner_t(Vs... vs) {
template <some_field_value... Vs> constexpr explicit owner_t(Vs... vs) {
using defaulted_fields = boost::mp11::mp_transform<
name_for,
boost::mp11::mp_copy_if<boost::mp11::mp_list<Fields...>,
Expand All @@ -493,7 +493,7 @@ struct message {
}

template <detail::storage_like S, some_field_value... Vs>
explicit constexpr owner_t(S const &s, Vs... vs) {
constexpr explicit owner_t(S const &s, Vs... vs) {
static_assert(std::is_same_v<typename S::value_type,
typename storage_t::value_type>,
"Attempted to construct owning message with "
Expand All @@ -506,7 +506,7 @@ struct message {
}

template <detail::storage_like S, some_field_value... Vs>
explicit constexpr owner_t(view_t<S> s, Vs... vs)
constexpr explicit owner_t(view_t<S> s, Vs... vs)
: owner_t{s.data(), vs...} {}

[[nodiscard]] constexpr auto data() LIFETIMEBOUND {
Expand Down
Loading