Skip to content

✨ Add target for string collateral #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
Merged

✨ Add target for string collateral #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cmake/string_catalog.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ function(gen_str_catalog)
VERSION
GUID_ID
GUID_MASK
MODULE_ID_MAX)
MODULE_ID_MAX
OUTPUTS_TARGET)
set(multiValueArgs INPUT_JSON INPUT_LIBS INPUT_HEADERS STABLE_JSON)
cmake_parse_arguments(SC "${options}" "${oneValueArgs}" "${multiValueArgs}"
${ARGN})
Expand Down Expand Up @@ -87,4 +88,9 @@ function(gen_str_catalog)
add_library(${SC_OUTPUT_LIB} STATIC ${SC_OUTPUT_CPP})
target_link_libraries(${SC_OUTPUT_LIB} PUBLIC cib)
endif()
if(SC_OUTPUTS_TARGET)
add_custom_target(
${SC_OUTPUTS_TARGET} DEPENDS ${SC_OUTPUT_CPP} ${SC_OUTPUT_XML}
${SC_OUTPUT_JSON})
endif()
endfunction()
4 changes: 3 additions & 1 deletion test/log/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ gen_str_catalog(
GUID_ID
"01234567-89ab-cdef-0123-456789abcdef"
GUID_MASK
"ffffffff-ffff-ffff-ffff-ffffffffffff")
"ffffffff-ffff-ffff-ffff-ffffffffffff"
OUTPUTS_TARGET
test_catalog_json)

add_library(catalog_strings STATIC ${CMAKE_CURRENT_BINARY_DIR}/strings.cpp)
target_link_libraries(catalog_strings PUBLIC cib)
Expand Down
Loading