✨ Allow fmt formatter to format runtime enum values #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbeno
force-pushed
the
fmt-enum-formatting
branch
from
1ca5f87 to
efed86c
Compare
elbeno
changed the title
Problem: - Runtime enumerations cannot in general be formatted by the fmt formatter, but work fine with the binary formatter. Solution: - Decay enumeration values to their `underlying_type` iff no `format_as` function is provided for them.
elbeno
force-pushed
the
fmt-enum-formatting
branch
from
efed86c to
5c79744
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
underlying_typeiff noformat_asfunction is provided for them.