🎨 💥 Change msg::combine to msg::overlay
#764
Merged
+59
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbeno
force-pushed
the
clarify-message-combos
branch
from
fa3bd24 to
0aa56f0
Compare
lukevalenty
approved these changes
Sep 3, 2025
Problem: - `combine` is a generic name that doesn't contrast with `pack` and doesn't have a clear meaning. Solution: - Change `combine` to `overlay` to make it clearer what the operation is. - Clarify documentation around `overlay` and `pack` - Add docs regarding `relaxed_message`.
elbeno
force-pushed
the
clarify-message-combos
branch
from
0aa56f0 to
dfeacd4
Compare
| // resulting message layout: | ||
| // byte |0 |1 | | ||
| // bit |01234567|01234567| | ||
| // field |header |payload | |
There was a problem hiding this comment.
question: is data_f specified incorrectly above? Should it be:
using data_f = field<"data", std::uint32_t>::located<at{0_dw, 15_msb, 8_lsb}>;optionally, if the intent is to show overlap the table can be rendered differently.
elbeno
added a commit
to elbeno/compile-time-init-build
that referenced
this pull request
Sep 3, 2025
Problem: - A field is incorrectly located. Solution: - Fix it. Note: - From intel#764 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
combineis a generic name that doesn't contrast withpackand doesn't have a clear meaning.Solution:
combinetooverlayto make it clearer what the operation is.overlayandpackrelaxed_message.