Skip to content

Commit efbfd5c

Browse files
ULT renaming: Read Buffer tests
Related-To: NEO-2236 Signed-off-by: Adam Cetnerowski <[email protected]>
1 parent fa285af commit efbfd5c

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

opencl/test/unit_test/command_queue/enqueue_read_buffer_tests.cpp

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626

2727
using namespace NEO;
2828

29-
HWTEST_F(EnqueueReadBufferTypeTest, null_mem_object) {
29+
HWTEST_F(EnqueueReadBufferTypeTest, GivenNullBufferWhenReadingBufferThenInvalidMemObjectErrorIsReturned) {
3030
auto data = 1;
3131
auto retVal = clEnqueueReadBuffer(
3232
pCmdQ,
@@ -42,7 +42,7 @@ HWTEST_F(EnqueueReadBufferTypeTest, null_mem_object) {
4242
EXPECT_EQ(CL_INVALID_MEM_OBJECT, retVal);
4343
}
4444

45-
HWTEST_F(EnqueueReadBufferTypeTest, null_user_pointer) {
45+
HWTEST_F(EnqueueReadBufferTypeTest, GivenNullUserPointerWhenReadingBufferThenInvalidValueErrorIsReturned) {
4646
auto data = 1;
4747

4848
auto retVal = clEnqueueReadBuffer(
@@ -59,7 +59,7 @@ HWTEST_F(EnqueueReadBufferTypeTest, null_user_pointer) {
5959
EXPECT_EQ(CL_INVALID_VALUE, retVal);
6060
}
6161

62-
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, GPGPUWalker) {
62+
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, WhenReadingBufferThenGpgpuWalkerIsProgrammedCorrectly) {
6363
typedef typename FamilyType::GPGPU_WALKER GPGPU_WALKER;
6464

6565
srcBuffer->forceDisallowCPUCopy = true;
@@ -93,15 +93,15 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, GPGPUWalker) {
9393
}
9494
}
9595

96-
HWTEST_F(EnqueueReadBufferTypeTest, bumpsTaskLevel) {
96+
HWTEST_F(EnqueueReadBufferTypeTest, WhenReadingBufferThenTaskLevelIsIncremented) {
9797
auto taskLevelBefore = pCmdQ->taskLevel;
9898

9999
srcBuffer->forceDisallowCPUCopy = true;
100100
EnqueueReadBufferHelper<>::enqueueReadBuffer(pCmdQ, srcBuffer.get(), CL_TRUE);
101101
EXPECT_GT(pCmdQ->taskLevel, taskLevelBefore);
102102
}
103103

104-
HWTEST_F(EnqueueReadBufferTypeTest, alignsToCSR_Blocking) {
104+
HWTEST_F(EnqueueReadBufferTypeTest, GivenBlockingWhenReadingBufferThenAlignedToCsr) {
105105
//this test case assumes IOQ
106106
auto &csr = pDevice->getUltCommandStreamReceiver<FamilyType>();
107107
csr.taskCount = pCmdQ->taskCount + 100;
@@ -114,7 +114,7 @@ HWTEST_F(EnqueueReadBufferTypeTest, alignsToCSR_Blocking) {
114114
EXPECT_EQ(oldCsrTaskLevel, pCmdQ->taskLevel);
115115
}
116116

117-
HWTEST_F(EnqueueReadBufferTypeTest, alignsToCSR_NonBlocking) {
117+
HWTEST_F(EnqueueReadBufferTypeTest, GivenNonBlockingWhenReadingBufferThenAlignedToCsr) {
118118
//this test case assumes IOQ
119119
auto &csr = pDevice->getUltCommandStreamReceiver<FamilyType>();
120120
csr.taskCount = pCmdQ->taskCount + 100;
@@ -125,15 +125,15 @@ HWTEST_F(EnqueueReadBufferTypeTest, alignsToCSR_NonBlocking) {
125125
EXPECT_EQ(csr.peekTaskLevel(), pCmdQ->taskLevel + 1);
126126
}
127127

128-
HWTEST_F(EnqueueReadBufferTypeTest, addsCommands) {
128+
HWTEST_F(EnqueueReadBufferTypeTest, WhenReadingBufferThenCommandsAreAdded) {
129129
auto usedCmdBufferBefore = pCS->getUsed();
130130

131131
srcBuffer->forceDisallowCPUCopy = true;
132132
EnqueueReadBufferHelper<>::enqueueReadBuffer(pCmdQ, srcBuffer.get(), CL_TRUE);
133133
EXPECT_NE(usedCmdBufferBefore, pCS->getUsed());
134134
}
135135

136-
HWTEST_F(EnqueueReadBufferTypeTest, addsIndirectData) {
136+
HWTEST_F(EnqueueReadBufferTypeTest, WhenReadingBufferThenIndirectDataIsAdded) {
137137
auto dshBefore = pDSH->getUsed();
138138
auto iohBefore = pIOH->getUsed();
139139
auto sshBefore = pSSH->getUsed();
@@ -165,7 +165,7 @@ HWTEST_F(EnqueueReadBufferTypeTest, addsIndirectData) {
165165
}
166166
}
167167

168-
HWTEST_F(EnqueueReadBufferTypeTest, LoadRegisterImmediateL3CNTLREG) {
168+
HWTEST_F(EnqueueReadBufferTypeTest, WhenReadingBufferThenLoadRegisterImmediateL3CntlregIsCorrect) {
169169
srcBuffer->forceDisallowCPUCopy = true;
170170
enqueueReadBuffer<FamilyType>();
171171
validateL3Programming<FamilyType>(cmdList, itorWalker);
@@ -183,7 +183,7 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, WhenEnqueueIsDoneThenStat
183183
pDSH, pIOH, pSSH, itorPipelineSelect, itorWalker, cmdList, 0llu);
184184
}
185185

186-
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, MediaInterfaceDescriptorLoad) {
186+
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, WhenReadingBufferThenMediaInterfaceDescriptorLoadIsCorrect) {
187187
typedef typename FamilyType::MEDIA_INTERFACE_DESCRIPTOR_LOAD MEDIA_INTERFACE_DESCRIPTOR_LOAD;
188188
typedef typename FamilyType::INTERFACE_DESCRIPTOR_DATA INTERFACE_DESCRIPTOR_DATA;
189189

@@ -212,7 +212,7 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, MediaInterfaceDescriptorL
212212
FamilyType::PARSE::template validateCommand<MEDIA_INTERFACE_DESCRIPTOR_LOAD *>(cmdList.begin(), itorCmd);
213213
}
214214

215-
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, InterfaceDescriptorData) {
215+
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, WhenReadingBufferThenInterfaceDescriptorDataIsCorrect) {
216216
typedef typename FamilyType::MEDIA_INTERFACE_DESCRIPTOR_LOAD MEDIA_INTERFACE_DESCRIPTOR_LOAD;
217217
typedef typename FamilyType::STATE_BASE_ADDRESS STATE_BASE_ADDRESS;
218218
typedef typename FamilyType::INTERFACE_DESCRIPTOR_DATA INTERFACE_DESCRIPTOR_DATA;
@@ -250,20 +250,20 @@ HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, InterfaceDescriptorData)
250250
EXPECT_NE(0u, IDD.getConstantIndirectUrbEntryReadLength());
251251
}
252252

253-
HWTEST_F(EnqueueReadBufferTypeTest, PipelineSelect) {
253+
HWTEST_F(EnqueueReadBufferTypeTest, WhenReadingBufferThenPipelineSelectIsProgrammedOnce) {
254254
srcBuffer->forceDisallowCPUCopy = true;
255255
enqueueReadBuffer<FamilyType>();
256256
int numCommands = getNumberOfPipelineSelectsThatEnablePipelineSelect<FamilyType>();
257257
EXPECT_EQ(1, numCommands);
258258
}
259259

260-
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, MediaVFEState) {
260+
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, WhenReadingBufferThenMediaVfeStateIsCorrect) {
261261
srcBuffer->forceDisallowCPUCopy = true;
262262
enqueueReadBuffer<FamilyType>();
263263
validateMediaVFEState<FamilyType>(&pDevice->getHardwareInfo(), cmdMediaVfeState, cmdList, itorMediaVfeState);
264264
}
265265

266-
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, blockingRequiresPipeControlAfterWalkerWithDCFlushSet) {
266+
HWCMDTEST_F(IGFX_GEN8_CORE, EnqueueReadBufferTypeTest, GivenBlockingWhenReadingBufferThenPipeControlAfterWalkerWithDcFlushSetIsAdded) {
267267
typedef typename FamilyType::PIPE_CONTROL PIPE_CONTROL;
268268

269269
srcBuffer->forceDisallowCPUCopy = true;
@@ -604,7 +604,7 @@ HWTEST_F(EnqueueReadBufferTypeTest, givenForcedCpuCopyWhenEnqueueReadCompressedB
604604
EXPECT_TRUE(mockCmdQ->cpuDataTransferHandlerCalled);
605605
}
606606

607-
HWTEST_F(EnqueueReadBufferTypeTest, gicenEnqueueReadBufferCalledWhenLockedPtrInTransferPropertisIsNotAvailableThenItIsNotUnlocked) {
607+
HWTEST_F(EnqueueReadBufferTypeTest, givenEnqueueReadBufferCalledWhenLockedPtrInTransferPropertisIsNotAvailableThenItIsNotUnlocked) {
608608
DebugManagerStateRestore dbgRestore;
609609
DebugManager.flags.DoCpuCopyOnReadBuffer.set(1);
610610

0 commit comments

Comments
 (0)