feat: No-Scan changes for html reports #5284
Open
+295
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: joydeep049 <[email protected]>
Signed-off-by: joydeep049 <[email protected]>
…o noscan-OPEngine-Update2 chore: merge with main
Signed-off-by: joydeep049 <[email protected]>
Signed-off-by: joydeep049 <[email protected]>
alex-ter
reviewed
Aug 15, 2025
| @@ -371,7 +377,55 @@ def test_empty_cve_list(self) -> None: | |||
| self.html_report_page.load() | |||
| product_rows = self.html_report_page.product_rows | |||
|
|
|||
| expect(product_rows).to_have_count(0) | |||
| # With the new implementation, products without CVEs are still displayed | |||
There was a problem hiding this comment.
Nit: here it says "the new implementation", and in the updated docstring above it says "the current implementation". I'd suggest reformulating both to drop this new/current references and simply state what the behavior is. It is assumed that it describes the logic this code implements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @terriko @anthonyharrison @mastersans