Skip to content

Update utils path in submodule#940

Merged
awherr merged 1 commit intomasterfrom
fix_submodules
Mar 5, 2025
Merged

Update utils path in submodule#940
awherr merged 1 commit intomasterfrom
fix_submodules

Conversation

@awherr
Copy link
Contributor

@awherr awherr commented Mar 5, 2025

Description

This PR fixes build post-migration

Related Issue

Motivation and Context

This is an artifact of migrating submodule dependencies

How Has This Been Tested?

As demonstrated by a successful build

Screenshots

Checklist:

  • I have read the CONTRIBUTING document.
  • I have updated the relevant documentation.
  • I have added tests for new logic.

@dkorlovs
Copy link
Contributor

dkorlovs commented Mar 5, 2025

pip3 install -r requirements leads to:
ERROR: Cannot install -r requirements.txt (line 14), -r requirements.txt (line 9) and requests==2.31.0 because these package versions have conflicting dependencies.

The conflict is caused by:
The user requested requests==2.31.0
curlify 2.2.1 depends on requests
granulate-utils 0.0.2.post56+git.c680a46c depends on requests~=2.32.0

@awherr awherr merged commit 482c3b7 into master Mar 5, 2025
28 checks passed
@awherr awherr deleted the fix_submodules branch March 5, 2025 18:59
@mlim19
Copy link
Contributor

mlim19 commented Mar 5, 2025

pip3 install -r requirements leads to: ERROR: Cannot install -r requirements.txt (line 14), -r requirements.txt (line 9) and requests==2.31.0 because these package versions have conflicting dependencies.

The conflict is caused by: The user requested requests==2.31.0 curlify 2.2.1 depends on requests granulate-utils 0.0.2.post56+git.c680a46c depends on requests~=2.32.0

I was able to resolve by updating the requirements file from 2.31.0 to 2.32.0. This should be done separately along with CVE fixes.

@dkorlovs
Copy link
Contributor

dkorlovs commented Mar 6, 2025

pip3 install -r requirements leads to: ERROR: Cannot install -r requirements.txt (line 14), -r requirements.txt (line 9) and requests==2.31.0 because these package versions have conflicting dependencies.
The conflict is caused by: The user requested requests==2.31.0 curlify 2.2.1 depends on requests granulate-utils 0.0.2.post56+git.c680a46c depends on requests~=2.32.0

I was able to resolve by updating the requirements file from 2.31.0 to 2.32.0. This should be done separately along with CVE fixes.

I know, I thought it would make sense to fix it also.

prashantbytesyntax pushed a commit to pinterest/gprofiler that referenced this pull request Jul 23, 2025
Co-authored-by: awherr <Adam Herr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants