Update llvm commit #363
Merged
Update llvm commit #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Better to describe the reason why we need to update the commit it, like this upstream contains a specific fix/update on certain feature? |
Author
Okay~ Added detailed explanation in the PR. |
ciyongch
approved these changes
Sep 27, 2024
zhczhong
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to fix ci segmentation fault error in PR100.
When we need to determine whether
linalg.genericis a matmul operation, we will use upstreamisContractionBodyfunction, but it will throw seg fault error due to nullptr pointer. The null pointer issue has been fixed in this llvm commit.