Skip to content

[GpuOclRuntime] Avoid error when iterating over non-gpu devices #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[GpuOclRuntime] Avoid error when iterating over non-gpu devices #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/gc/ExecutionEngine/GPURuntime/ocl/GpuOclRuntime.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ OclRuntime::gcIntelDevices(size_t max) {

for (auto platform : platforms) {
cl_uint numDevices;
err = clGetDeviceIDs(platform, CL_DEVICE_TYPE_GPU, 0, nullptr, &numDevices);
err = clGetDeviceIDs(platform, CL_DEVICE_TYPE_ALL, 0, nullptr, &numDevices);
if (err != CL_SUCCESS) {
gcLogE("Failed to get the number of devices on the platform.", platform,
" Error: ", err);
Expand All @@ -363,7 +363,7 @@ OclRuntime::gcIntelDevices(size_t max) {
}

SmallVector<cl_device_id> devices(numDevices);
err = clGetDeviceIDs(platform, CL_DEVICE_TYPE_GPU, numDevices,
err = clGetDeviceIDs(platform, CL_DEVICE_TYPE_ALL, numDevices,
devices.data(), nullptr);
if (err != CL_SUCCESS) {
gcLogE("Failed to get the device ids on the platform ", platform,
Expand All @@ -372,6 +372,9 @@ OclRuntime::gcIntelDevices(size_t max) {
}

for (auto dev : devices) {
cl_device_type deviceType;
clGetDeviceInfo(dev, CL_DEVICE_TYPE, sizeof(deviceType), &deviceType,
nullptr);
cl_uint vendorId;
err = clGetDeviceInfo(dev, CL_DEVICE_VENDOR_ID, sizeof(cl_uint),
&vendorId, nullptr);
Expand All @@ -380,6 +383,8 @@ OclRuntime::gcIntelDevices(size_t max) {
continue;
}
if (vendorId == 0x8086) {
if (!(deviceType & CL_DEVICE_TYPE_GPU))
continue;
intelDevices.emplace_back(dev);
#ifndef NDEBUG
size_t nameSize;
Expand Down