-
Notifications
You must be signed in to change notification settings - Fork 16
[LinalgToXeGPU] Support squeezable any-D memrefs #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dchigarev <[email protected]>
Signed-off-by: dchigarev <[email protected]>
Signed-off-by: dchigarev <[email protected]>
dchigarev
commented
Nov 29, 2024
Comment on lines
208
to
217
| while (auto subViewOp = memref.getDefiningOp<memref::SubViewOp>()) { | ||
| auto currentOffsets = getAsOpFoldResult(resolvedOffsets); | ||
| resolvedOffsets.clear(); | ||
|
|
||
| affine::resolveIndicesIntoOpWithOffsetsAndStrides( | ||
| rewriter, memref.getLoc(), subViewOp.getMixedOffsets(), | ||
| subViewOp.getMixedStrides(), subViewOp.getDroppedDims(), currentOffsets, | ||
| resolvedOffsets); | ||
| memref = subViewOp.getOperand(0); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the logic was taken from XeGPUFoldAliasOps upstream pass
Signed-off-by: dchigarev <[email protected]>
Signed-off-by: dchigarev <[email protected]>
kurapov-peter
approved these changes
Dec 2, 2024
Contributor
kurapov-peter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, fine otherwise
AndreyPavlenko
approved these changes
Dec 2, 2024
Signed-off-by: dchigarev <[email protected]>
Signed-off-by: dchigarev <[email protected]>
1ffaa03 to
e3994c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows any-D memrefs to be used in
linalg-to-xegpupass as long they can be squeezed to a 2D memref through leading dimensions. Example:The
linalg-to-xegpulogic considers a linalg operation that can be lowered to xegpu and checks the operand shapes. The old logic refused alllinalgOpsthat have non-2D operands. The new logic additionally checks if a non-2D operand can be squeezed to a 2D and allows them if they can. It then squeezes the non-2D operand usingmemref.subviewand replaces old operands with new 2D memrefs. Example: