Add support to build UBI based images #2203
Conversation
build/docker/templates/intel-idxd-config-initcontainer.Dockerfile.in
Outdated
Show resolved
Hide resolved
|
Do we (still) have reasons to keep two somewhat different flavors in one Dockerfile. For the normal dockerhub publishing flows in our repo, we can get the tag from from any source |
To build UBI based images, set UBI=1 for the make command. For idxd or levelzero images, the build host needs to be registered to RH (subscription-manager) so packages can be installed from repositories. Signed-off-by: Tuomas Katila <[email protected]>
idxd-config-initcontainer and gpu-levelzero are not built as they require repositories which are not available in GH. Signed-off-by: Tuomas Katila <[email protected]>
tkatila
force-pushed
the
ubi-base-images
branch
from
295b932 to
d8b6dc6
Compare
|
Discussed with @mythi offline. I split the idxd and levelzero Dockerfiles into two (one for deb, one for rpm). This has the benefit of removing the if statements from the Dockerfiles. Building image works the same way: |
eero-t
left a comment
eero-t
left a comment
There was a problem hiding this comment.
Seems fine now, except for use of unstable repo, that should be explained.
Signed-off-by: Tuomas Katila <[email protected]>
tkatila
force-pushed
the
ubi-base-images
branch
from
d8b6dc6 to
bdf39d7
Compare
| ### | ||
| ARG CMD=gpu_levelzero | ||
| ## At the time of writing this, 9.6 is the latest supported version for Intel GPU repos. | ||
| ARG FINAL_BASE_UBI=registry.access.redhat.com/ubi9/ubi:9.6 |
There was a problem hiding this comment.
FINAL_BASE_UBI does not seem to be used in Makefile. Is that intentional?
There was a problem hiding this comment.
Yes. It's an ARG here only as it's used both in the build and the final phases.
3 participants
Fixes: #1693