Skip to content

Conversation

@alexbaden
Copy link
Contributor

Adds the new AttrsDescriptor back and adds a __repr__ method so we can easily serialize it to the generated Inductor code.

I am leaving this draft as the changes for both the __repr__ method and Inductor changes are under review.

Close #2421

@alexbaden alexbaden force-pushed the alex/new_attrs_desc branch 3 times, most recently from 2a1be45 to 60b1c99 Compare October 18, 2024 17:49
@alexbaden alexbaden marked this pull request as ready for review October 18, 2024 18:27
@alexbaden
Copy link
Contributor Author

alexbaden commented Oct 18, 2024

@alexbaden
Copy link
Contributor Author

@whitneywhtsang this is ready for review.

Copy link
Contributor

@whitneywhtsang whitneywhtsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM, can we squash the last 3 commits, and do not squash and merge this PR, so they we can keep the commit history?

@alexbaden alexbaden force-pushed the alex/new_attrs_desc branch from 2b47135 to c6e60f0 Compare October 22, 2024 12:39
@alexbaden
Copy link
Contributor Author

The change LGTM, can we squash the last 3 commits, and do not squash and merge this PR, so they we can keep the commit history?

Done. I only have squash permissions, can you do the rebase and merge?

@whitneywhtsang whitneywhtsang merged commit 6293c4b into main Oct 22, 2024
4 checks passed
@whitneywhtsang whitneywhtsang deleted the alex/new_attrs_desc branch October 22, 2024 14:25
@whitneywhtsang
Copy link
Contributor

The change LGTM, can we squash the last 3 commits, and do not squash and merge this PR, so they we can keep the commit history?

Done. I only have squash permissions, can you do the rebase and merge?

Thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Triton Upstream] AttrsDescriptor class refactoring breaks Torch Inductor

4 participants