[Triton] Use UnitAttr in tt.reshape definition
#2497
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `UnitAttr` in `tt.reshape` definition to make working with them and creating them easier. `allow_reorder` and `efficient_layout` are now `UnitAttr`, allowing dropping the additional constructor. Signed-off-by: victor-eds <[email protected]>
Contributor
Author
|
Noticed this flaw when working with the operation. Will make working with it cleaner. Worth upstreaming. |
Contributor
Author
|
Now we get the very convenient: static ReshapeOp build(/*...,*/ Type type, Value src, bool allowReorder = false, bool efficientLayout = false); |
Contributor
Author
|
Make code needed for #2266 simpler. |
Contributor
Author
|
If the Intel side is happy with this, I'll push a PR upstream. This isn't blocking us, but it may make working with this op easier. |
Contributor
whitneywhtsang
left a comment
whitneywhtsang
left a comment
There was a problem hiding this comment.
LGTM, let's upstream it.
whitneywhtsang
approved these changes
Oct 17, 2024
Contributor
Author
Contributor
Author
|
Closing as upstream PR is up for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
UnitAttrintt.reshapedefinition to make working with them and creating them easier.allow_reorderandefficient_layoutare nowUnitAttr, allowing dropping the additional constructor.