Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions python/test/unit/language/print_helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,20 +131,15 @@ def test_print(func: str, data_type: str, device: str):
else:
assert f"Unknown kernel: {func}"

if device == "xpu":
# FIXME: remove trigger to get output from kernel
repr(x)
repr(y)
# Wait until driver complete all the jobs for the device_print, especially test_subprocess
# require this which captures stdout when child exits.
getattr(torch, device).synchronize()

if func != "print_no_arg" and func != "no_arg_print" and func != "device_print_large" and \
func != "print_multiple_args" and func != "device_print_multiple_args" and \
func != "device_print_pointer" and func != "device_print_scalar":
assert_close(y, x)

# Wait until driver complete all the jobs for the device_print, especially test_subprocess
# require this which captures stdout when child exits.
getattr(torch, device).synchronize()
Comment on lines -144 to -146
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to move this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, first of all the synchronize should be called.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be done in upstream as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, I have created the upstream PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to move this?

even with the new driver?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to move this?

even with the new driver?

yes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check if these tests work with 2025.0.0 without moving these lines?
It was checked in Aug, and at that time, they work with 2025.0.0.



if __name__ == "__main__":
fn = globals()[sys.argv[1]]
Expand Down
2 changes: 0 additions & 2 deletions scripts/skiplist/a770/subprocess.txt

This file was deleted.

9 changes: 0 additions & 9 deletions scripts/skiplist/conda/subprocess.txt

This file was deleted.

9 changes: 0 additions & 9 deletions scripts/skiplist/default/subprocess.txt

This file was deleted.

9 changes: 0 additions & 9 deletions scripts/skiplist/lts/subprocess.txt

This file was deleted.

9 changes: 0 additions & 9 deletions scripts/skiplist/no-basekit/subprocess.txt

This file was deleted.