Skip to content

Fix coverity issues #2515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmyachev merged 2 commits into from
Oct 21, 2024
Merged

Fix coverity issues #2515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24f95ab
Fix coverity issues
anmyachev Oct 20, 2024
8d5057d
use const& for AxisInfo constructors
anmyachev Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions third_party/intel/include/Analysis/AxisInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,12 @@ class AxisInfo {
public:
AxisInfo() : AxisInfo({}, {}, {}) {}

AxisInfo(DimVectorT contiguity, DimVectorT divisibility, DimVectorT constancy)
AxisInfo(const DimVectorT &contiguity, const DimVectorT &divisibility,
const DimVectorT &constancy)
: AxisInfo(contiguity, divisibility, constancy, std::nullopt) {}

AxisInfo(DimVectorT contiguity, DimVectorT divisibility, DimVectorT constancy,
std::optional<int64_t> constantValue)
AxisInfo(const DimVectorT &contiguity, const DimVectorT &divisibility,
const DimVectorT &constancy, std::optional<int64_t> constantValue)
: contiguity(contiguity), divisibility(divisibility),
constancy(constancy), constantValue(constantValue) {
assert(divisibility.size() == contiguity.size());
Expand Down
2 changes: 1 addition & 1 deletion third_party/intel/lib/Analysis/AxisInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1344,7 +1344,7 @@ void ModuleAxisInfoAnalysis::initialize(FunctionOpInterface funcOp) {
} else {
curAxisInfo = axisInfo;
}
(*axisInfoMap)[value] = curAxisInfo;
(*axisInfoMap)[value] = std::move(curAxisInfo);
};
funcOp.walk([&](Operation *op) {
for (auto value : op->getResults()) {
Expand Down