Skip to content

Enable 3d dot #2518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
etiotto merged 14 commits into from
Oct 31, 2024
Merged

Enable 3d dot #2518

etiotto merged 14 commits into from
Oct 31, 2024

Conversation

@leonling-ll
Copy link
Contributor

@leonling-ll leonling-ll commented Oct 21, 2024 •
edited
Loading

This pull request enable 3d dot.
With this change, we can pass 161 test_core.py::test_dot3d unit test cases.

@leonling-ll leonling-ll linked an issue Oct 21, 2024 that may be closed by this pull request
[test_core.py::test_dot3d] fails to run correctly on PVC #500
Closed
@leonling-ll leonling-ll self-assigned this Oct 21, 2024
@leonling-ll
Support rank>2 to dpas/dot layout conversion
e800858 
Fix 3d dot layout to llvm

Fix opIdx to dimIdx
etiotto
etiotto reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@etiotto etiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the test in test_core.py work now ?

@leonling-ll
Copy link
Contributor Author

leonling-ll commented Oct 25, 2024

Does the test in test_core.py work now ?

It can take the 3D tensor input and lowering to the end, but the result is incorrect.
It should be the indices calculation issue, I'm working on figuring them out.

@leonling-ll leonling-ll marked this pull request as ready for review October 29, 2024 08:04
@leonling-ll leonling-ll changed the title [Draft] Enable 3d dot lowering Enable 3d dot Oct 29, 2024
@leonling-ll leonling-ll requested review from a team and hwnam831 October 29, 2024 11:45
etiotto
etiotto reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@etiotto etiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the skip lists need to be updated (e.g. scripts/skiplist/default/language.txt) like you did for scripts/skiplist/a770/language.txt).

etiotto
etiotto reviewed Oct 29, 2024
View reviewed changes
victor-eds
victor-eds reviewed Oct 30, 2024
View reviewed changes
victor-eds added a commit to victor-eds/intel-xpu-backend-for-triton that referenced this pull request Oct 30, 2024
@victor-eds
[OptRed] Do not assert on reductions after 3D dot ops
2a6234d 
Triton supports 3D dot operations and intel#2518 enables them. Avoid
assertions when this pass finds reductions of 3D tensors.

Signed-off-by: Victor Perez <[email protected]>
@victor-eds victor-eds mentioned this pull request Oct 30, 2024
Merged
victor-eds added a commit that referenced this pull request Oct 30, 2024
@victor-eds
[OptRed] Do not assert on reductions after 3D dot ops (#2590)
e438919 
Triton supports 3D dot operations and #2518 enables using them with
`DpasEncodingAttr` encoding. Avoid assertions when this pass finds
reductions of 3D tensors.

Signed-off-by: Victor Perez <[email protected]>
@etiotto
Copy link
Contributor

etiotto commented Oct 30, 2024 •
edited
Loading

Latest run shows:

language: passed: 10859, failed: 0, skipped: 170, xfailed: 1017, total: 12046, fixme: 0, pass rate (w/o xfailed): 98.46%

The skipped are too many. @LiyangLingIntel can you update all the skip lists please ?

@chengjunlu chengjunlu force-pushed the liyang/enable_dot3d branch 3 times, most recently from aee2336 to 9a65f8a Compare October 31, 2024 04:48
@chengjunlu
Copy link
Contributor

chengjunlu commented Oct 31, 2024

Latest run shows:

language: passed: 10859, failed: 0, skipped: 170, xfailed: 1017, total: 12046, fixme: 0, pass rate (w/o xfailed): 98.46%

The skipped are too many. @LiyangLingIntel can you update all the skip lists please ?

Removed 3d dot cases from the default and xe2 config skip lists.

@etiotto
Copy link
Contributor

etiotto commented Oct 31, 2024

language: passed: 11020, failed: 0, skipped: 9, xfailed: 1017, total: 12046, fixme: 0, pass rate (w/o xfailed): 99.92%

@etiotto etiotto merged commit 55702d9 into main Oct 31, 2024
4 checks passed
@etiotto etiotto deleted the liyang/enable_dot3d branch October 31, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etiotto etiotto etiotto approved these changes

@whitneywhtsang whitneywhtsang Awaiting requested review from whitneywhtsang

@chengjunlu chengjunlu Awaiting requested review from chengjunlu

@hwnam831 hwnam831 Awaiting requested review from hwnam831

+1 more reviewer

@victor-eds victor-eds victor-eds approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@leonling-ll leonling-ll

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[test_core.py::test_dot3d] fails to run correctly on PVC

5 participants

@leonling-ll @etiotto @chengjunlu @victor-eds