[OptRed] Extend -tritonintelgpu-optimize-reduction-locality to support repCluster[0] > 2
#2533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-eds
requested review from
a team,
chengjunlu,
etiotto and
whitneywhtsang
Contributor
Author
|
Part of #2266. |
…ort `repCluster[0] > 2` Support `repCluster[0] > 2` by using 7-D tensors and adding a `convert_layout` operation before the final `reshape`. See code for implementation details. Signed-off-by: victor-eds <[email protected]>
victor-eds
force-pushed
the
fast-sub-group-transpose-extend
branch
from
fdd0512 to
6f74535
Compare
jopperm
reviewed
Oct 24, 2024
third_party/intel/lib/TritonIntelGPUTransforms/OptimizeReductionLocality.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUTransforms/OptimizeReductionLocality.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUTransforms/OptimizeReductionLocality.cpp
Show resolved
Hide resolved
etiotto
approved these changes
Oct 24, 2024
jopperm
approved these changes
Oct 31, 2024
Contributor
jopperm
left a comment
jopperm
left a comment
There was a problem hiding this comment.
Some minor documentation nits, but LGTM otherwise!
third_party/intel/lib/TritonIntelGPUTransforms/OptimizeReductionLocality.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUTransforms/OptimizeReductionLocality.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUTransforms/OptimizeReductionLocality.cpp
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUTransforms/OptimizeReductionLocality.cpp
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
repCluster[0] > 2by using 7-D tensors and adding aconvert_layoutoperation before the finalreshape.See code for implementation details.
Signed-off-by: victor-eds [email protected]