Skip to content

Dump SPIRV kernel in benchmark_driver.py #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anmyachev merged 1 commit into from
Oct 23, 2024
Merged

Dump SPIRV kernel in benchmark_driver.py #2535

anmyachev merged 1 commit into from
Oct 23, 2024

Conversation

@anmyachev
Copy link
Contributor

@anmyachev anmyachev commented Oct 22, 2024 •
edited
Loading

Closes #2536

Mostly copying from #2258 with minor code style adjustments.

@anmyachev anmyachev marked this pull request as ready for review October 22, 2024 22:50
@chengjunlu
Copy link
Contributor

chengjunlu commented Oct 23, 2024

This PR is LGTM.
BTW: Can we unify the XPU launcher of microbench to the one in Triton XPU? It reduce our effort to sync the changes on the launcher.
There is already some environments to control the legacy profiling stubs in the launcher.

kballeda
kballeda approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@kballeda kballeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anmyachev : This looks good, Thank you !

@anmyachev anmyachev mentioned this pull request Oct 23, 2024
Closed
@anmyachev
Copy link
Contributor Author

anmyachev commented Oct 23, 2024

This PR is LGTM. BTW: Can we unify the XPU launcher of microbench to the one in Triton XPU? It reduce our effort to sync the changes on the launcher. There is already some environments to control the legacy profiling stubs in the launcher.

I will take a look: #2540

@anmyachev anmyachev merged commit 61fd54d into main Oct 23, 2024
5 checks passed
@anmyachev anmyachev deleted the amyachev/update-benchmark-driver branch October 23, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chengjunlu chengjunlu chengjunlu approved these changes

+2 more reviewers

@alexbaden alexbaden alexbaden approved these changes

@kballeda kballeda kballeda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dump SPIRV kernel in benchmark_driver.py

5 participants

@anmyachev @chengjunlu @alexbaden @kballeda