Skip to content

Less verbose auto-update-translator-cid #2551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pbchekin merged 2 commits into from
Oct 24, 2024
Merged

Less verbose auto-update-translator-cid #2551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca3f086
Less verbose check-update-translator-cid
pbchekin Oct 24, 2024
e22ca09
`env` is not needed
pbchekin Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/auto-update-translator-cid.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ jobs:
- name: Search the latest valid Translator cid
if: ${{ env.TARGET_PRID == null }}
run: |
env
./scripts/check-update-translator-cid.sh $CID_LATEST $CID_CURRENT
if git status --porcelain ./lib/Target/SPIRV/spirv-llvm-translator.conf | grep '^ M'; then
echo "MODIFIED=true" >> $GITHUB_ENV
Expand Down
17 changes: 13 additions & 4 deletions scripts/check-update-translator-cid.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,22 @@ cd $TRITON_PROJ
FOUND=false
for cid in $COMMIT_IDS; do
echo "$cid" > ./lib/Target/SPIRV/spirv-llvm-translator.conf
if ! ./scripts/compile-triton.sh --clean; then
echo "Triton compile failed for translator commit $cid"

BUILD_STATUS=PASS
echo "::group::Building Triton for $cid"
./scripts/compile-triton.sh --clean || BUILD_STATUS=FAIL
echo "::endgroup::"

if [ $BUILD_STATUS != PASS ]; then
continue
fi

# execute default tests
if ./scripts/test-triton.sh --skip-pytorch-install; then
TEST_STATUS=PASS
echo "::group::Testing Triton for $cid"
./scripts/test-triton.sh --skip-pytorch-install || TEST_STATUS=FAIL
echo "::endgroup::"

if [ $TEST_STATUS = PASS ]; then
echo "Tests passed for translator commit $cid"
echo "A newer commit found: $cid"
FOUND=true
Expand Down
2 changes: 1 addition & 1 deletion scripts/compile-triton.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ build_triton() {

cd python
# Install triton and its dependencies.
pip install -vvv -e '.[build,tests]'
pip install -v -e '.[build,tests]'

# Copy compile_commands.json in the build directory (so that cland vscode plugin can find it).
cp $(find $TRITON_PROJ_BUILD -name compile_commands.json) $TRITON_PROJ/
Expand Down