Skip to content

[ENH] Improve packaging of benchmarks #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vlad-penkin merged 2 commits into from
Oct 25, 2024
Merged

[ENH] Improve packaging of benchmarks #2572

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acf7a5f
[ENH] Improve packaging of benchmarks
vlad-penkin Oct 24, 2024
25d1598
[FIX] Benchmarks setup.py - remediate pylint and yapf is
vlad-penkin Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 34 additions & 8 deletions benchmarks/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,37 @@ def run(self):
super().run()


setup(name="triton-kernels-benchmark", packages=[
"triton_kernels_benchmark",
], package_dir={
"triton_kernels_benchmark": "triton_kernels_benchmark",
}, package_data={"triton_kernels_benchmark": ["xetla_kernel.cpython-*.so"]}, cmdclass={
"build_ext": build_ext,
"clean": clean,
}, ext_modules=[CMakeExtension("triton_kernels_benchmark")])
def get_git_commit_hash(length=8):
try:
cmd = ["git", "rev-parse", f"--short={length}", "HEAD"]
return f"+git{subprocess.check_output(cmd).strip().decode('utf-8')}"
except (
FileNotFoundError,
subprocess.CalledProcessError,
subprocess.TimeoutExpired,
):
return ""


setup(
name="triton-kernels-benchmark",
version="3.1.0" + get_git_commit_hash(),
Copy link
Contributor

@pbchekin pbchekin Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 3.1.0?

Copy link
Contributor Author

@vlad-penkin vlad-penkin Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To indicate matching triton version.

packages=["triton_kernels_benchmark"],
install_requires=[
"torch",
"pandas",
"tabulate",
"matplotlib",
],
package_dir={"triton_kernels_benchmark": "triton_kernels_benchmark"},
package_data={"triton_kernels_benchmark": ["xetla_kernel.cpython-*.so"]},
cmdclass={
"build_ext": build_ext,
"clean": clean,
},
ext_modules=[CMakeExtension("triton_kernels_benchmark")],
extra_require={
"ipex": ["numpy<=2.0", "intel-extension-for-pytorch=2.1.10"],
Copy link
Contributor

@anmyachev anmyachev Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we have to use the version defined by the pin here: https://github.com/intel/intel-xpu-backend-for-triton/blob/main/.github/pins/ipex.txt?

"pytorch": ["torch>=2.6"],
},
)