[TritonIntelGPUToLLVM] Detect more sub-group shuffle convert_layout
#2573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-eds
commented
Oct 25, 2024
Comment on lines
+531
to
+541
| int32_t registerInDimSize = conversion->getInDimSize(kRegister); | ||
| int32_t laneInDimSize = conversion->getInDimSize(kLane); | ||
| return conversion->getBases().lookup(kRegister) == | ||
| buildSubGroupTransposeRegisterBases(registerInDimSize, | ||
| laneInDimSize) && | ||
| conversion->getBases().lookup(kLane) == | ||
| buildSubGroupTransposeLaneBases(laneInDimSize); |
Contributor
Author
There was a problem hiding this comment.
Refactor and protected against some illegal layout creation.
|
|
||
| LinearLayout comp = dstLayout.invertAndCompose(srcLayout); | ||
| std::optional<LinearLayout> conversion = comp.divideRight( | ||
| LinearLayout::zeros1D(comp.getInDimSize(kLane), kLane, kLane) * |
Contributor
Author
There was a problem hiding this comment.
Should always be 0 for this case
Comment on lines
647
to
648
| if (!conversion) | ||
| return false; |
Contributor
Author
There was a problem hiding this comment.
May be None is 0 check fails.
Detect sub-group shuffle `convert_layout` cases of more than one element per thread. Signed-off-by: victor-eds <[email protected]>
victor-eds
force-pushed
the
sub-group-shuffle-broadcast-extend
branch
from
cb1d9f5 to
a7277b1
Compare
victor-eds
commented
Oct 28, 2024
Comment on lines
+674
to
+676
| conversion->getBases().lookup(kRegister) == | ||
| buildSubGroupShuffleRegisterBases(registerInDimSize, | ||
| laneOutDimSize); |
Contributor
Author
There was a problem hiding this comment.
I will investigate whether there is a better way to express this in the future when generalizing. Same for transpose case.
etiotto
approved these changes
Oct 30, 2024
mfrancepillois
approved these changes
Oct 30, 2024
mfrancepillois
left a comment
mfrancepillois
left a comment
There was a problem hiding this comment.
I'm missing some background on subgroup shuffle, but PR LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect sub-group shuffle
convert_layoutcases of more than one element per thread.