[FA] Remove TRITON_INTEL_ENABLE_INSTR_SCHED
#2578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Whitney Tsang <[email protected]>
This reverts commit 35c3e09.
Signed-off-by: Whitney Tsang <[email protected]>
whitneywhtsang
requested review from
Dewei-Wang-sh,
chengjunlu,
etiotto and
leonling-ll
chengjunlu
approved these changes
Oct 28, 2024
Contributor
|
is this because IGC can support it now? |
Contributor
Author
Yes, IGC improved instruction scheduling in agama 996. |
Dewei-Wang-sh
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A 5% geomean improvement is observed on FA advanced path with
TRITON_INTEL_ENABLE_INSTR_SCHEDremoved.CI: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/11541276782, https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/11540829777