Add libsycl path to RPATH to runtime build #2608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZzEeKkAa
force-pushed
the
feature/pip_sycl_rt
branch
from
bbf0804 to
a9a4288
Compare
|
@vlad-penkin this is a critical fix for PyTorch pip install feature. Please help to prioritize this PR merge asap. After Triton repo ready, we still need time to pin Triton upgrade, and upstream pip install feature and then testing. |
etiotto
approved these changes
Nov 1, 2024
|
|
||
|
|
||
| def _build(name, src, srcdir, library_dirs, include_dirs, libraries): | ||
| def _build(name, src, srcdir, library_dirs, include_dirs, libraries, extra_compile_args=[]): |
Contributor
There was a problem hiding this comment.
This change in common file should be upstreamed. Can you open an issue so you can do that separately please ?
pbchekin
reviewed
Nov 1, 2024
ZzEeKkAa
force-pushed
the
feature/pip_sycl_rt
branch
from
a9a4288 to
2835632
Compare
ZzEeKkAa
force-pushed
the
feature/pip_sycl_rt
branch
from
2835632 to
72249e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make wheel package work in pip environment