Use pytest' tmp_path fixture instead of tempfile.NamedTemporaryFile
#2609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoly Myachev <[email protected]>
pbchekin
approved these changes
Nov 1, 2024
Contributor
There was a problem hiding this comment.
Looks good! One question below, plus:
- Do you think it is reasonable to annotate
tmp_pathastmp_path: pathlib.Path? Other arguments are not annotated, so it is a questionable change. - We can also upstream first small changes to Proton's
start(and potentially other Triton functions) that accept a file name asstrto acceptos.PathLikewhich can bestrorpathlib.Path. This will minimize changes in this PR:proton.start(str(temp_file))will beproton.start(temp_file).
| assert pathlib.Path(proton.DEFAULT_PROFILE_NAME + ".hatchet").exists() | ||
| default_file = pathlib.Path(proton.DEFAULT_PROFILE_NAME + ".hatchet") | ||
| assert default_file.exists() | ||
| default_file.unlink() |
Contributor
There was a problem hiding this comment.
Do we need this unlink? The whole tmp_path should be deleted on exit.
Contributor
Author
There was a problem hiding this comment.
it seems yes, because default_file defined using the default name of the proton itself, which may not be in the temporary folder
Contributor
Author
|
In the upstream: triton-lang/triton@a273986 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking before upstreaming to Triton.