-
Notifications
You must be signed in to change notification settings - Fork 78
Benchmarks subset #2614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmarks subset #2614
Conversation
|
Test run with skipped GEMM and Softmax https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/11788616521/job/32836016215 |
| - name: Run Triton GEMM kernel benchmark | ||
| if: ${{ steps.install.outcome == 'success' && !cancelled() }} | ||
| if: ${{ steps.install.outcome == 'success' && !cancelled() && !contains(inputs.skip_benchmarks, 'gemm_benchmark.py') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contains(inputs.skip_benchmarks, 'gemm_benchmark.py') returns true if the skip list contains gemm_benchmark.py_default or gemm_benchmark.py_advanced. Is it expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is true if the input is a JSON list, see the test run with ['softmax_kernel.py','gemm_benchmark.py']: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/11788616521/job/32836016215
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How contains knows this is json and not a string? The input type iof skip_benchmarks is string and there is no fromJSON...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How
containsknows this is json and not a string? The input type iofskip_benchmarksisstringand there is nofromJSON...
I don't know, let's add this for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is now fixed: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/11803428969/job/32881355590
//upd: not sure, there's some errors...
pbchekin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it simpler to add input checkboxes for each benchmark?
I've tried, but number of inputs is limited to 10 |
…intel-xpu-backend-for-triton into feature/benchmarks-subset
Co-authored-by: Pavel Chekin <[email protected]>
Co-authored-by: Pavel Chekin <[email protected]>
Co-authored-by: Pavel Chekin <[email protected]>
pbchekin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Let's merge and see how daily run work.
|
Thanks for your contribution! |
Related to #2522