Remove packaging from dependencies
#2866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
commented
Nov 28, 2024
| except importlib.metadata.PackageNotFoundError: | ||
| raise AssertionError(assertion_message) | ||
|
|
||
| if Version(sycl_rt.get("version", "0.0.0")) in SpecifierSet("<2025.0.0a1"): |
Contributor
Author
There was a problem hiding this comment.
This check is quite easy to emulate using strings and their methods. I think using packaging here is overcomplicating.
Signed-off-by: Anatoly Myachev <[email protected]>
pbchekin
approved these changes
Nov 28, 2024
Contributor
pbchekin
left a comment
pbchekin
left a comment
There was a problem hiding this comment.
The check for version can be improved IMHO, but it is good enough for now. We can revisit later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.