Merge OpenAI Triton commit 390e27f
#2944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ision gemm (bf16 x s8) (#5337) In the closed PR triton-lang/triton#4768, I have written the python + lit tests cases for Ampere small-tile-size mixed precision gemm (bf16 x s8). While the compilation crash is solved by another PR, the test cases can be added. <!--- The core Triton is a small number of people, and we receive many PRs (thank you!). To help us review your code more quickly, **if you are a new contributor (less than 3 PRs merged) we ask that you complete the following tasks and include the filled-out checklist in your PR description.** Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> # New contributor declaration - [x] I am not making a trivial change, such as fixing a typo in a comment. - [x] I have written a PR description following these [rules](https://cbea.ms/git-commit/#why-not-how). - [x] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`. - Select one of the following. - [x] I have added tests. - `/test` for `lit` tests - `/unittest` for C++ tests - `/python/test` for end-to-end tests - [ ] This PR does not need a test because `FILL THIS IN`. - Select one of the following. - [ ] I have not added any `lit` tests. - [ ] The `lit` tests I have added follow these [best practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices), including the "tests should be minimal" section. (Usually running Python code and using the instructions it generates is not minimal.) --------- Co-authored-by: Christian Sigg <[email protected]>
Reverts triton-lang/triton#5308 This is causing functional regressions in some internal tests
Reverts triton-lang/triton#5281 Reverting this as well since llvm merge has been revert
Introduce `emitHardwareTuple` helper that emits the code to compute the blockId, warpId, and laneId for a thread and returns them. This PR uses this helper in a few places.
Integrate code sequence made by @rawnhenry for efficient fp4 upcasting Co-authored-by: Rawn Henry <[email protected]>
For `uint64_t` the literal `K` is used, which means `unsigned long long` according to https://docs.python.org/3/c-api/arg.html#numbers. It seems logical and correct to use literal `L` for type `int64_t`, which means `long long` C type. Signed-off-by: Anatoly Myachev <[email protected]>
This reverts commit a876742.
pbchekin
approved these changes
Dec 5, 2024
anmyachev
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change the Triton base from a4f1854 to 390e27f (Dec 5).
Pass rate: 93.27%->93.31%
Please do not squash and merge this PR.