Skip to content

Windows related cleanup in runtime/build.py #2964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmyachev merged 1 commit into from
Dec 8, 2024
Merged

Windows related cleanup in runtime/build.py #2964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions python/triton/runtime/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import shutil
import subprocess
import setuptools
import platform


def is_xpu():
Expand All @@ -25,7 +24,7 @@ def quiet():


def _cc_cmd(cc, src, out, include_dirs, library_dirs, libraries):
if cc in ["cl", "clang-cl"]:
if os.name == "nt":
cc_cmd = [cc, src, "/nologo", "/O2", "/LD"]
cc_cmd += [f"/I{dir}" for dir in include_dirs]
cc_cmd += [f"/Fo{os.path.join(os.path.dirname(out), 'main.obj')}"]
Expand All @@ -36,9 +35,7 @@ def _cc_cmd(cc, src, out, include_dirs, library_dirs, libraries):
cc_cmd += [f"/LIBPATH:{dir}" for dir in library_dirs]
cc_cmd += [f'{lib}.lib' for lib in libraries]
else:
cc_cmd = [cc, src, "-O3", "-shared", "-Wno-psabi"]
if os.name != "nt":
cc_cmd += ["-fPIC"]
cc_cmd = [cc, src, "-O3", "-shared", "-fPIC", "-Wno-psabi"]
cc_cmd += [f'-l{lib}' for lib in libraries]
cc_cmd += [f"-L{dir}" for dir in library_dirs]
cc_cmd += [f"-I{dir}" for dir in include_dirs]
Expand All @@ -57,8 +54,8 @@ def _build(name, src, srcdir, library_dirs, include_dirs, libraries, extra_compi
clang = shutil.which("clang")
gcc = shutil.which("gcc")
cc = gcc if gcc is not None else clang
if platform.system() == "Windows":
cc = "cl"
if os.name == "nt":
cc = shutil.which("cl")
if cc is None:
raise RuntimeError("Failed to find C compiler. Please specify via CC environment variable.")
# This function was renamed and made public in Python 3.10
Expand Down Expand Up @@ -115,7 +112,7 @@ def _build(name, src, srcdir, library_dirs, include_dirs, libraries, extra_compi
language='c',
sources=[src],
include_dirs=include_dirs,
extra_compile_args=extra_compile_args + ['-O3' if "-O3" in cc_cmd else "/O2"],
extra_compile_args=extra_compile_args + ['-O3' if os.name != "nt" else "/O2"],
extra_link_args=extra_link_args,
library_dirs=library_dirs,
libraries=libraries,
Expand Down