Implement arch_parser.c as pure dll
#3230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmyachev
force-pushed
the
amyachev/arch-parser-pure-dll
branch
from
489671d to
3b7e649
Compare
Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
force-pushed
the
amyachev/arch-parser-pure-dll
branch
from
3b7e649 to
fa6c686
Compare
anmyachev
commented
Jan 22, 2025
| self.shared_library.dlclose(handle) | ||
| else: | ||
|
|
||
| def __del__(self): |
Contributor
Author
There was a problem hiding this comment.
Using a pure dll, it is possible to unload the library from the process memory, which is important for Windows (considering the tests that fail). I also rewrote this module for Linux, since using Python for it seems overcomplicated.
Signed-off-by: Anatoly Myachev <[email protected]>
pbchekin
approved these changes
Jan 23, 2025
whitneywhtsang
pushed a commit
that referenced
this pull request
Feb 18, 2025
The same motivation as for #3251 and #3230 --------- Signed-off-by: Anatoly Myachev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should avoid issues like:
ImportError: DLL load failed while importing arch_utils: The parameter is incorrect.on windows. One could see this issue here: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/12901598261/job/35973923326.As a result, this may solve the following problem (if we make such a change for all modules): #3090
After this PR this issue still exists, for example for
__triton_launcher:CI:
Ref: python/cpython#114538