Skip to content

Disable fp64 patch #3663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 5, 2025
Merged

Disable fp64 patch #3663

merged 15 commits into from
May 5, 2025

Conversation

@kwasd
Copy link
Contributor

@kwasd kwasd commented Mar 13, 2025 •
edited
Loading

status in #2946

@kwasd
Copy link
Contributor Author

kwasd commented Mar 16, 2025

#2946

@etiotto
Copy link
Contributor

etiotto commented Mar 27, 2025

@kwasd are you still pursuing this PR ?

@kwasd
Copy link
Contributor Author

kwasd commented Apr 7, 2025 •
edited
Loading

Yes, it will be marked as done once A770 workflows are finished.

@kwasd kwasd changed the title [draft] Disable fp64 patch [testing] Disable fp64 patch Apr 14, 2025
@etiotto
Copy link
Contributor

etiotto commented Apr 28, 2025

The workflows above are finished. What is it blocking this issue @kwasd ?

@kwasd kwasd changed the title [testing] Disable fp64 patch Disable fp64 patch May 5, 2025
@kwasd
Copy link
Contributor Author

kwasd commented May 5, 2025

@etiotto See status table in #2946. Tests are ok, however benchmarks are long, now with Pavel and Anatoly we are discussing on merging this PR to assess benchmarking results offline later.

@kwasd kwasd requested a review from anmyachev May 5, 2025 10:00
@kwasd kwasd marked this pull request as ready for review May 5, 2025 10:00
anmyachev
anmyachev reviewed May 5, 2025
View reviewed changes
@anmyachev anmyachev merged commit fdcf859 into main May 5, 2025
13 of 16 checks passed
@anmyachev anmyachev deleted the fix/try-disabling-fp64-patch branch May 5, 2025 13:30
@kwasd kwasd restored the fix/try-disabling-fp64-patch branch May 6, 2025 19:06
anmyachev added a commit that referenced this pull request Jun 12, 2025
@anmyachev
Revert "Disable fp64 patch (#3663)"
3b00889 
This reverts commit fdcf859.
anmyachev added a commit that referenced this pull request Jun 12, 2025
@anmyachev
Revert "Disable fp64 patch (#3663)"
86874e8 
This reverts commit fdcf859.

Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev added a commit that referenced this pull request Jun 12, 2025
@anmyachev
Revert "Disable fp64 patch (#3663)"
cb459eb 
This reverts commit fdcf859.

Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev added a commit that referenced this pull request Jun 13, 2025
@anmyachev
Revert "Disable fp64 patch (#3663)"
d1166d5 
This reverts commit fdcf859.

Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev added a commit that referenced this pull request Jun 13, 2025
@anmyachev
Revert "Disable fp64 patch (#3663)" (#4494)
d40cfc5 
Signed-off-by: Anatoly Myachev <[email protected]>
whitneywhtsang pushed a commit that referenced this pull request Jun 19, 2025
@anmyachev @whitneywhtsang
Revert "Disable fp64 patch (#3663)" (#4494)
724aaf6 
Signed-off-by: Anatoly Myachev <[email protected]>
(cherry picked from commit d40cfc5)
whitneywhtsang added a commit that referenced this pull request Jun 19, 2025
@whitneywhtsang @anmyachev
Revert "Disable fp64 patch (#3663)" (#4494) (#4546)
eaffba4 
(cherry picked from commit d40cfc5)

Signed-off-by: Anatoly Myachev <[email protected]>
Co-authored-by: Anatoly Myachev <[email protected]>
@kwasd kwasd deleted the fix/try-disabling-fp64-patch branch June 30, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmyachev anmyachev anmyachev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kwasd @etiotto @anmyachev