Skip to content

Fix the setTargetTriple API usage in SPIRV translation #3930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

Fix the setTargetTriple API usage in SPIRV translation #3930

merged 1 commit into from
Apr 16, 2025

Conversation

kurapov-peter
Copy link
Contributor

This fixes the build with the spirv backend.

anmyachev
anmyachev approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@anmyachev anmyachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's because of llvm/llvm-project#129868, right?

@kurapov-peter
Copy link
Contributor Author

it's because of llvm/llvm-project#129868, right?

Yup

@kurapov-peter kurapov-peter merged commit e9608d8 into main Apr 16, 2025
5 checks passed
@kurapov-peter kurapov-peter deleted the pakurapo/spv-triple branch April 16, 2025 19:44
@anmyachev anmyachev mentioned this pull request Jun 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmyachev anmyachev anmyachev approved these changes

@VyacheslavLevytskyy VyacheslavLevytskyy Awaiting requested review from VyacheslavLevytskyy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurapov-peter @anmyachev