Skip to content

Add dot3d[8-2-64-64-64-32-32-float32-float32] to skiplists #3937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025
Merged

Add dot3d[8-2-64-64-64-32-32-float32-float32] to skiplists #3937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scripts/skiplist/default/language.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
# https://github.com/intel/intel-xpu-backend-for-triton/issues/3556
test/unit/language/test_core.py::test_convert_mma2mma[mma_pair0-float16-256-256]
# https://github.com/intel/intel-xpu-backend-for-triton/issues/3870
test/unit/language/test_core.py::test_dot3d[8-2-64-64-64-32-32-float32-float32]
2 changes: 2 additions & 0 deletions scripts/skiplist/xe2/language.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# https://github.com/intel/intel-xpu-backend-for-triton/issues/3870
test/unit/language/test_core.py::test_dot3d[8-2-64-64-64-32-32-float32-float32]
7 changes: 2 additions & 5 deletions third_party/intel/lib/TritonIntelGPUToLLVM/DotOpToLLVM/DPAS.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,11 +338,8 @@ class DotOpDPASConversionHelper {
totalElems /
((batch * outer * inner) * (repClusterOuter * repClusterInner));
VectorType dotOpTy = vec_ty(elemTy, numElemsPerOperand);
// TODO: IGC bug, Update isFToTF32Enabled as follows once issue #3870 is
// fixed. isFToTF32Enabled = elemTy.isFloat(32) && (isOperandA ||
// isOperandB)
isFToTF32Enabled = elemTy.isFloat(32) &&
((rank == 3) ? isOperandA : (isOperandA || isOperandB));

isFToTF32Enabled = elemTy.isFloat(32) && (isOperandA || isOperandB);

auto tb = TritonLLVMOpBuilder(loc, rewriter);
int offset = 0;
Expand Down
Loading