Split core test group to minicore, mxfp, scaled-dot #3993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwasd
approved these changes
Apr 23, 2025
gshimansky
approved these changes
Apr 23, 2025
anmyachev
approved these changes
Apr 23, 2025
whitneywhtsang
approved these changes
Apr 23, 2025
david-hls
pushed a commit
to david-hls/intel-xpu-backend-for-triton
that referenced
this pull request
Jun 18, 2025
This caching seems to be responsible for some CUDA OOMs we encountered in Meta-internal builds. I haven't got a reduced repro, but this change does seem to fix things. My hypothesis is that the cached stream is causing the memory allocated for the graph to be retained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 3 new command line options to
scripts/test-triton.sh:--minicore,--mxfp,--scaled_dot.The semantic of
--coreis not changed: it should execute the same tests as before.Additionally,
--minicoreshould be much faster than--core, and the remaining tests from core group can be executed separately with--mxfp --scaled_dot.Required for #3976.