Skip to content

xfail instead of skip matmul tests #5397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
Merged

xfail instead of skip matmul tests #5397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions python/test/unit/language/test_matmul.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1218,14 +1218,14 @@ def test_mxfp8_mxfp4_matmul(M, N, K, BLOCK_M, BLOCK_N, BLOCK_K, NUM_STAGES, B_TR
pytest.skip("Float4 without scale is tested in test_block_scale_fp4")
elif is_xpu():
if not (WITH_A_SCALE and WITH_B_SCALE):
pytest.skip("None scale has not been tested on XPU backend")
pytest.xfail("None scale has not been tested on XPU backend")
if not (A_DATA_TYPE == "float8e5" and B_DATA_TYPE == "float4"):
pytest.skip(f"(A: {A_DATA_TYPE}, B: {B_DATA_TYPE}) has not been tested on XPU backend")
pytest.xfail(f"(A: {A_DATA_TYPE}, B: {B_DATA_TYPE}) has not been tested on XPU backend")
if (BLOCK_M, BLOCK_N,
BLOCK_K) == (128, 256,
256) and CONST_SCALE and triton.runtime.driver.active.utils.get_device_properties(
triton.runtime.driver.active.get_current_device())["max_shared_mem"] < 196608:
pytest.skip("XPU: Not enough shared memory")
pytest.xfail("XPU: Not enough shared memory")
if not PACK_B_ALONG_K and B_DATA_TYPE != "float4":
pytest.xfail("Pack along K can only be False for float4")

Expand Down
Loading