Adjust unit test after upstream AxisAnalysis changes. #5593
+34
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etiotto
requested review from
anmyachev,
chengjunlu and
whitneywhtsang
and removed request for
whitneywhtsang
etiotto
commented
Dec 2, 2025
anmyachev
approved these changes
Dec 2, 2025
Contributor
anmyachev
left a comment
anmyachev
left a comment
There was a problem hiding this comment.
LGTM. I wonder if this change affects performance?
etiotto
changed the title
Contributor
Author
Benchmark run: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/19872998954 |
chengjunlu
approved these changes
Dec 3, 2025
Contributor
Author
|
The benchmark run I kicked off above showed a degradation in flex attention for one shape (144 TFlops -> 131 TFlops): 
However I rerun the benchmark one more time (https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/19902682824/job/57050650262) and got: 
Also the degradation was not reproducible locally on a PVC1100 machine. So false alarm. |
…sis (#8758)" This reverts commit 546a718.
Signed-off-by: Ettore Tiotto <[email protected]>
etiotto
force-pushed
the
etiotto.fix_5588
branch
from
fd4bd70 to
8571d94
Compare
whitneywhtsang
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.