Merge OpenAI Triton commit dcad270
#5598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If building from root `CMakeLists.txt`, we will have an empty `CMAKE_LIBRARY_OUTPUT_DIRECTORY`, then this will try to create `/plugins` and see permission failures.
This PR fixes test failures in `test_dot_multidim` that occur on AMD
RDNA3 GPUs due to overly strict floating-point comparisons.
The test currently uses `torch.equal()` which requires exact bit-for-bit
equality, but different GPU architectures and drivers can produce
slightly different results at the machine epsilon level
while still being mathematically correct. This change replaces the exact
equality check with `torch.allclose()` using appropriate tolerances.
Triton --> tensor([[[[ -3.0000, -44.0000, 8.0000, ..., 1.0000, -28.0000,
-12.0000],
[ -6.0000, 46.0000, 10.0000, ..., -13.0000, 35.0000, 50.0000],
[ 83.0000, 5.0000, 59.0000, ..., -32.0000, -19.0000, 96.0000],
...,
Torch ---> tensor([[[[ -3., -44., 8., ..., 1., -28., -12.],
[ -6., 46., 10., ..., -13., 35., 50.],
[ 83., 5., 59., ..., -32., -19., 96.],
...,
The printed values appear identical, but `torch.equal()` detects
differences at the least significant bits level.
anmyachev
force-pushed
the
amyachev/merge118
branch
from
a17ce02 to
e33b846
Compare
Contributor
Author
anmyachev
force-pushed
the
amyachev/merge118
branch
from
e33b846 to
4dfb7ff
Compare
anmyachev
force-pushed
the
amyachev/merge118
branch
from
4dfb7ff to
83eb05c
Compare
…t None and do_gamma is set Signed-off-by: Witold Dziurdz <[email protected]> (cherry picked from commit 1479afd) Signed-off-by: Anatoly Myachev <[email protected]>
whitneywhtsang
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Triton base from e4e68d1 to dcad270 (Nov 23).
Pass rate: 95.42%->95.86%