display verbose message when build failed.

[xuhancn]

Issue:
When triton build failed, it missed verbose error message display.

Fixing:
It referenced to PyTorch cpp_builder code, to show verbose error message: https://github.com/pytorch/pytorch/blob/2bec68e73b64715354af076ad309335f943e36cd/torch/_inductor/cpp_builder.py#L613-L631

Local validation:
After this fixing, it should shows the verbose build fail message:

New contributor declaration

• I am not making a trivial change, such as fixing a typo in a comment.

• I have written a PR description following these
  rules.

• I have run pre-commit run --from-ref origin/main --to-ref HEAD.

• Select one of the following.

  • I have added tests.
    • /test for lit tests
    • /unittest for C++ tests
    • /python/test for end-to-end tests
  • This PR does not need a test because FILL THIS IN.

• Select one of the following.

  • I have not added any lit tests.
  • The lit tests I have added follow these best practices,
    including the "tests should be minimal" section. (Usually running Python code
    and using the instructions it generates is not minimal.)

[anmyachev]

Hi @xuhancn. Thanks for your contribution!

Let's try simplifying the code. Does this work for you?

Suggested change

	try:
	subprocess.run(cc_cmd, check=True, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
	except subprocess.CalledProcessError as e:
	output = e.stdout.decode(*SUBPROCESS_DECODE_ARGS)
	raise RuntimeError(output)
	subprocess.check_output(cc_cmd, stderr=subprocess.STDOUT, encoding=locale.getpreferredencoding())

[xuhancn]

Hi @anmyachev I think my code is better, we'd better keep try-except block. It is working well in PyTorch for a long time.

[anmyachev]

We have one more criterion: how much the code deviates from the upstream. I use this as a guide when trying to modify your code. The smaller it is, the easier it is to support for us and potentially upstream it.

Several things from docs: https://docs.python.org/3.10/library/subprocess.html#subprocess.check_output

• This is equivalent to: run(..., check=True, stdout=PIPE).stdout
• If the return code was non-zero it raises a CalledProcessError. The CalledProcessError object will have the return code in the returncode attribute and any output in the output attribute.

The main reason why you use try-except is to decode the output (at least I see it like this). However, if immediately pass encoding to the call command, then this is not necessary.

[anmyachev]

Closes #3760

[anmyachev]

If I haven't convinced you, you can merge the changes as is.