Keep sub and jcc in sequence to enable macrofusion. #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablodelara
reviewed
Sep 22, 2025
There was a problem hiding this comment.
Thanks @Shark64. There is still an issue, could you look into it? Thanks!
raid/xor_gen_sse.asm
Outdated
| xor DWORD(pos), DWORD(pos) | ||
|
|
||
| loop128: | ||
| mov tmp2, [arg2+tmp*PS] ;Fetch last pointer in array |
There was a problem hiding this comment.
tmp is not set on the first pass here, unlike earlier. xor_gen_test is failing for SSE only architectures.
You can check this Intel SDE tool, using sde -snr -- ./raid/xor_gen_test
There was a problem hiding this comment.
Uh, you're right. I did check with sde for AVX but forgot to check the SSE codepath. Sorry about that, i just put the right register there, with that we don't need the mov altogether. Thx
There was a problem hiding this comment.
BTW I've squashed the last commit message into the main one. This should make ```check_format.sh''' happy (I think)
Signed-off-by: Nicola Torracca <[email protected]>
Shark64
force-pushed
the
macrofusion-2
branch
from
d643844 to
55cd7aa
Compare
|
This is merged now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we talked in the other pull request, this is the "lite" version. Only enabling macrofusion for loops and setting registers to zero in the right way.