Remove unsecure library loading by removing marker file logic on Android#168
Merged
eparshut merged 2 commits intointel:masterfrom Jan 14, 2025
Merged
Remove unsecure library loading by removing marker file logic on Android#168eparshut merged 2 commits intointel:masterfrom
eparshut merged 2 commits intointel:masterfrom
Conversation
abrown
approved these changes
Jan 13, 2025
Contributor
abrown
left a comment
abrown
left a comment
There was a problem hiding this comment.
Makes sense to me, but others should probably chime in (specifically, anyone who may have needed this Android logic in the past!).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the library loading mechanism in the ITT library by removing the logic that searches for a marker file in various directories on Android. This change enhances security by eliminating the risk of loading arbitrary libraries from world-writable directories . The library will now be loaded from the environment variable only for all platforms.