|
14 | 14 | // REQUIRES: linux |
15 | 15 | // |
16 | 16 | // Explanation of the command: |
17 | | -// - search for all "XFAIL" occurences, display line with match and the next one |
| 17 | +// - search for all "XFAIL" occurrences, display line with match and the next one |
18 | 18 | // -I, --include to drop binary files and other unrelated files |
19 | | -// - in the result, serach for "XFAIL" again, but invert the result - this |
| 19 | +// - in the result, search for "XFAIL" again, but invert the result - this |
20 | 20 | // allows us to get the line *after* XFAIL |
21 | 21 | // - in those lines, check that XFAIL-TRACKER is present and correct. Once |
22 | 22 | // again, invert the search to get all "bad" lines |
|
29 | 29 | // RUN: grep -Pv "XFAIL-TRACKER:\s+(?:https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)|(?:[\w]+-[\d]+)" | \ |
30 | 30 | // RUN: wc -l | FileCheck %s --check-prefix NUMBER-OF-XFAIL-WITHOUT-TRACKER |
31 | 31 | // |
32 | | -// The number below is a number of tests which are *impropertly* XFAIL-ed, i.e. |
| 32 | +// The number below is a number of tests which are *improperly* XFAIL-ed, i.e. |
33 | 33 | // we either don't have a tracker associated with a failure listed in those |
34 | 34 | // tests, or it is listed in a wrong format. |
35 | 35 | // Note: strictly speaking, that is not amount of files, but amount of XFAIL |
36 | 36 | // directives. If a test contains several XFAIL directives, some of them may be |
37 | 37 | // valid and other may not. |
38 | 38 | // |
39 | | -// That number *must not* increase. Any PR which causes this number to group |
| 39 | +// That number *must not* increase. Any PR which causes this number to grow |
40 | 40 | // should be rejected and it should be updated to either keep the number as-is |
41 | 41 | // or have it reduced (preferrably, down to zero). |
42 | 42 | // |
43 | 43 | // If you see this test failed for your patch, it means that you either |
44 | 44 | // introduced XFAIL directive to a test improperly, or broke the format of an |
45 | 45 | // existing XFAIL-ed tests. |
46 | 46 | // Another possibility (and that is a good option) is that you updated some |
47 | | -// tests to match the requried format and in that case you should just update |
| 47 | +// tests to match the required format and in that case you should just update |
48 | 48 | // (i.e. reduce) the number below. |
49 | 49 | // |
50 | 50 | // NUMBER-OF-XFAIL-WITHOUT-TRACKER: 176 |
0 commit comments