Skip to content

[SYCL] Impl of fallback group sort in device code #12676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 120 commits into
base: sycl
Choose a base branch
from
Draft

[SYCL] Impl of fallback group sort in device code #12676

wants to merge 120 commits into from

Conversation

@jinge90
Copy link
Contributor

@jinge90 jinge90 commented Feb 9, 2024

No description provided.

@jinge90 jinge90 requested a review from a team as a code owner February 9, 2024 07:52
@jinge90 jinge90 marked this pull request as draft February 9, 2024 07:52
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@jinge90
Copy link
Contributor Author

jinge90 commented Feb 9, 2024

Hi, @andreyfe1
Could you take a look at this draft patch?
Thanks very much.

@jinge90
remove commented code
33c2df4 
Signed-off-by: jinge90 <[email protected]>
andreyfe1
andreyfe1 reviewed Feb 23, 2024
View reviewed changes
Copy link
Contributor

@andreyfe1 andreyfe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall. Thanks for the great work

@jinge90 jinge90 temporarily deployed to WindowsCILock March 1, 2024 07:00 — with GitHub Actions Inactive
@jinge90
sync with latest head
11f2a13 
Signed-off-by: jinge90 <[email protected]>
@jinge90
fix clang format issue
877af07 
Signed-off-by: jinge90 <[email protected]>
@jinge90
fix clang format
7d87a89 
Signed-off-by: jinge90 <[email protected]>
@jinge90
Fix cmake issue
4e486b4 
Signed-off-by: jinge90 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aelovikov-intel aelovikov-intel Awaiting requested review from aelovikov-intel aelovikov-intel is a code owner automatically assigned from intel/llvm-reviewers-runtime

@andreyfe1 andreyfe1 Awaiting requested review from andreyfe1

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jinge90 @andreyfe1