-
Notifications
You must be signed in to change notification settings - Fork 799
[UR] disable hwloc support for UMF #14812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,9 @@ option(SYCL_PI_UR_USE_FETCH_CONTENT | |
set(SYCL_PI_UR_SOURCE_DIR | ||
"" CACHE PATH "Path to root of Unified Runtime repository") | ||
|
||
option(SYCL_UMF_DISABLE_HWLOC | ||
"Disable hwloc support in UMF" ON) | ||
|
||
# Here we override the defaults to disable building tests from unified-runtime | ||
set(UR_BUILD_EXAMPLES OFF CACHE BOOL "Build example applications." FORCE) | ||
set(UR_BUILD_TESTS OFF CACHE BOOL "Build unit tests." FORCE) | ||
|
@@ -113,22 +116,25 @@ if(SYCL_PI_UR_USE_FETCH_CONTENT) | |
endfunction() | ||
|
||
set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git") | ||
# commit b7b0c8b3d17aa7d511c67ec219d58091d07cfa60 | ||
# Merge: 2baf0951 5b8936da | ||
# commit a985a81dc9ba8adfcc8b54e35ad287e97766fb3e | ||
# Merge: b7b0c8b3 f772f907 | ||
# Author: Piotr Balcer <[email protected]> | ||
# Date: Fri Jul 26 15:48:04 2024 +0200 | ||
# Merge pull request #1903 from kswiecicki/umf-version-bump | ||
# Bump UMF version again | ||
set(UNIFIED_RUNTIME_TAG b7b0c8b3d17aa7d511c67ec219d58091d07cfa60) | ||
# Date: Mon Jul 29 09:11:29 2024 +0200 | ||
# Merge pull request #1905 from igchor/umf_hwloc_disable | ||
# Bump UMF version to allow disabling hwloc | ||
set(UNIFIED_RUNTIME_TAG a985a81dc9ba8adfcc8b54e35ad287e97766fb3e) | ||
|
||
set(UMF_BUILD_EXAMPLES OFF CACHE INTERNAL "EXAMPLES") | ||
# Due to the use of dependentloadflag and no installer for UMF and hwloc we need | ||
# to link statically on windows | ||
if(WIN32) | ||
set(UMF_BUILD_SHARED_LIBRARY OFF CACHE INTERNAL "Build UMF shared library") | ||
set(UMF_LINK_HWLOC_STATICALLY ON CACHE INTERNAL "static HWLOC") | ||
else() | ||
set(UMF_DISABLE_HWLOC ${SYCL_UMF_DISABLE_HWLOC} CACHE INTERNAL "disable hwloc for UMF") | ||
endif() | ||
|
||
|
||
pbalcer marked this conversation as resolved.
Show resolved
Hide resolved
|
||
fetch_adapter_source(level_zero | ||
${UNIFIED_RUNTIME_REPO} | ||
${UNIFIED_RUNTIME_TAG} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.